Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow jobs with dashes in the name by changing job marker. #6313

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

hanleyja
Copy link
Contributor

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Seems like a bugfix, so not sure what would need to be changed in the README.md

Currently, jobs with a dash in the jobid aren't captured correctly.

Copy link
Contributor

@glinton glinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, adding a space to the Split scared me at first, but I see in the tests that we are already testing full functionality.

@glinton glinton added the fix pr to fix corresponding bug label Aug 26, 2019
@danielnelson danielnelson added this to the 1.11.5 milestone Aug 27, 2019
@danielnelson danielnelson merged commit 17a79e2 into influxdata:master Aug 27, 2019
danielnelson pushed a commit that referenced this pull request Aug 27, 2019
bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request Oct 18, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants