Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containers can now be identified by the container ID #6473

Merged

Conversation

morfien101
Copy link
Contributor

@morfien101 morfien101 commented Oct 2, 2019

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

closes #6472

I'm not 100% sure of the config value name container_id_as_hostname, I'm happy to take some guidance on this.

This PR allows the user to set a config value to tag all measurements gathered by this plugin with the container_id, stripped down to the common hostname value.
It sets this in the host tag which telegraf expects to be set and will set itself if its not already set. This allows for backwards comparability with the current behaviour.

@danielnelson danielnelson added area/docker feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Oct 4, 2019
Change the readme and configuration samples to be the same.
Updated the README file to reflect the change.
@danielnelson danielnelson added this to the 1.13.0 milestone Oct 8, 2019
@danielnelson danielnelson merged commit a5294fd into influxdata:master Oct 8, 2019
athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docker feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker input plugin does not show the same container on many hosts well
2 participants