Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fibaro input: for battery operated devices, add battery level scraping #7319

Merged

Conversation

dynek
Copy link
Contributor

@dynek dynek commented Apr 13, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

This simply adds battery level scraping for battery operated devices, in order to be able to alert when a battery runs out of juice.

plugins/inputs/fibaro/fibaro.go Show resolved Hide resolved
Copy link
Contributor Author

@dynek dynek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssoroka is my answer fine by you?

plugins/inputs/fibaro/fibaro.go Show resolved Hide resolved
@ssoroka ssoroka merged commit 52a3f5d into influxdata:master Apr 20, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Apr 20, 2020

Looks good. Thanks for the PR!

@dynek dynek deleted the plugins_input_fibaro_add_battery_level branch April 20, 2020 15:01
veorlo pushed a commit to GlobalNOC/telegraf that referenced this pull request May 4, 2020
@danielnelson danielnelson added this to the 1.15.0 milestone May 22, 2020
@danielnelson danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 22, 2020
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants