Handle multiple metrics with the same timestamp in dedup plugin #7439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
approved these changes
Apr 29, 2020
| now, | ||
| ) | ||
| out = dedup.Apply(in) | ||
| require.Equal(t, []telegraf.Metric{in}, out) // pass |
There was a problem hiding this comment.
May want to use testutil.RequireMetricsEqual here for better error display. (I'm not sure if this is testing the pointer or the value)
| out = dedup.Apply(in) | ||
| require.Equal(t, []telegraf.Metric{in}, out) // pass | ||
|
|
||
| in, _ = metric.New("metric", |
There was a problem hiding this comment.
Should we split this into two tests?
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #7343