Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

input consul - added metric_version flag #7875

Merged
merged 3 commits into from
Oct 7, 2020

Conversation

unflag
Copy link
Contributor

@unflag unflag commented Jul 22, 2020

… to control how to populate tags/fields of telegraf metrics. Addresses:
closes #7871
closes #2646

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Вячеслав Митрофанов added 2 commits July 22, 2020 12:31
@danielnelson danielnelson added this to the 1.16.0 milestone Jul 22, 2020
@danielnelson danielnelson added area/consul feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jul 22, 2020
plugins/inputs/consul/consul.go Show resolved Hide resolved
## Metric version controls the mapping from Consul metrics into
## Telegraf metrics.
##
## example: metric_version = 1; deprecated in 1.15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also explain what changed between versions here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, thanks. I''ll add details about v2 into Metrics section.

@ssoroka ssoroka merged commit a452feb into influxdata:master Oct 7, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Co-authored-by: Вячеслав Митрофанов <vmitrofanov@mfms.ru>
@unflag unflag deleted the input_consul_metrics_v2 branch September 13, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/consul feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input consul - incompatible with output opentsdb Make consul service_id a tag.
3 participants