Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in lustre2 input plugin, when field name and value #7967

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Fix crash in lustre2 input plugin, when field name and value #7967

merged 1 commit into from
Jan 27, 2021

Conversation

omgold
Copy link
Contributor

@omgold omgold commented Aug 11, 2020

are not separated by whitespace, which happens when numbers grow large (#7966)

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Fix crash in lustre2 input plugin, when field name and value
1f1dccb 
are not separated by whitespace, which happens when numbers grow large (influxdata#7966)
ssoroka
ssoroka approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely better, but still seems like it might be prone to parse errors. Would be better to parse out the { } section, then split pairs by ,, then split key-value by :, and then trim each. You'd be 100% certain you don't have any other hidden bugs.

@sjwang90 sjwang90 added the fix pr to fix corresponding bug label Aug 11, 2020
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 11, 2020
@srebhan srebhan self-assigned this Dec 11, 2020
@ssoroka
Copy link
Contributor

ssoroka commented Jan 27, 2021

@omgold you available to respond to my comment?

@omgold
Copy link
Contributor Author

omgold commented Jan 27, 2021

@omgold you available to respond to my comment?

Ah, yes, your solution would be cleaner. Mine is just a quick fix which could break again. Unfortunately I don't have time to implement it currently.

@ssoroka ssoroka merged commit 8707a2d into influxdata:master Jan 27, 2021
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
@ssoroka
Fix crash in lustre2 input plugin, when field name and value (#7967)
a295e6d 
are not separated by whitespace, which happens when numbers grow large (#7966)

Co-authored-by: Oliver Mangold <o.mangold@gmail.com>
(cherry picked from commit 8707a2d)
@sjwang90 sjwang90 mentioned this pull request Jan 27, 2021
Closed
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Fix crash in lustre2 input plugin, when field name and value (influxd…
6895401 
…ata#7967)

are not separated by whitespace, which happens when numbers grow large (influxdata#7966)

Co-authored-by: Oliver Mangold <o.mangold@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@omgold @ssoroka @srebhan @sjwang90