Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix string to int conversion in eventhub consumer #8006

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix string to int conversion in eventhub consumer #8006

merged 1 commit into from
Aug 26, 2020

Conversation

pmalek-sumo
Copy link
Contributor

@pmalek-sumo pmalek-sumo commented Aug 19, 2020 •
edited
Loading

The existing conversion produces a vet check (which is enabled by default starting with 1.15) when running go test in 1.15 as per https://golang.org/doc/go1.15#vet.

$ make test
go test -short -race ./...
?       github.com/influxdata/telegraf  [no test files]
# github.com/influxdata/telegraf/plugins/inputs/eventhub_consumer
plugins/inputs/eventhub_consumer/eventhub_consumer.go:379:40: conversion from int16 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)
...

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@pmalek-sumo pmalek-sumo mentioned this pull request Aug 25, 2020
Closed
@reimda reimda merged commit 48bab9d into influxdata:master Aug 26, 2020
@reimda
Copy link
Contributor

reimda commented Aug 26, 2020

Thanks!

ssoroka pushed a commit that referenced this pull request Aug 29, 2020
@pmalek-sumo @ssoroka
Fix string to int conversion in eventhub consumer (#8006)
7a8f723
@pmalek-sumo pmalek-sumo deleted the fix-eventhub-consumer branch September 3, 2020 07:49
idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020
@pmalek-sumo
Fix string to int conversion in eventhub consumer (influxdata#8006)
50836ed
@MSIT-BPSC-IOT
Copy link

Why Prefetch_count is not working?

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@pmalek-sumo
Fix string to int conversion in eventhub consumer (influxdata#8006)
3a7662f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reimda reimda reimda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pmalek-sumo @reimda @MSIT-BPSC-IOT @pmalek