Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

outputs/http: add option to control idle connection timeout #8055

Merged
merged 1 commit into from
Dec 30, 2020
Merged

outputs/http: add option to control idle connection timeout #8055

merged 1 commit into from
Dec 30, 2020

Conversation

YuriGrigorov
Copy link
Contributor

This PR resolves the issue when Telegraf stays in front of Load Balancer.

Some servers has hardcoded IdleTimeut which is higher then 15 seconds (default Telegrafs keep-alive timeout). In this case Telegraf creates keep-alive connection and it is never closed because of reuse.

As a result, balancing does not work.

@sjwang90
Copy link
Contributor

sjwang90 commented Sep 16, 2020

Please rebase on master to fix the AppVeyor problem.

Also to clarify, this is for the outputs.http your title has inputs

@YuriGrigorov YuriGrigorov changed the title inputs/http: add option to control idle connection timeout outputs/http: add option to control idle connection timeout Sep 19, 2020
@YuriGrigorov
Copy link
Contributor Author

Please rebase on master to fix the AppVeyor problem.

Also to clarify, this is for the outputs.http your title has inputs

Done with rebase. And yes this is for the outputs.http.

@sjwang90 sjwang90 added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Nov 25, 2020
@sjwang90 sjwang90 added this to the Planned milestone Dec 9, 2020
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Could you please rebase again to get rid of the CI error!?

@srebhan srebhan self-assigned this Dec 11, 2020
@srebhan
Copy link
Contributor

srebhan commented Dec 11, 2020

Hey @YuriGrigorov why did you close the PR???

@YuriGrigorov YuriGrigorov reopened this Dec 11, 2020
@YuriGrigorov
Copy link
Contributor Author

Sorry for this. I screwed up with the rebase.

@YuriGrigorov
Copy link
Contributor Author

Yes! Finally! "All checks have passed"

@srebhan сould you please check if everything is ok?

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 11, 2020
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything ok in my view.

@sspaink sspaink merged commit c319e63 into influxdata:master Dec 30, 2020
@sspaink
Copy link
Contributor

sspaink commented Dec 30, 2020

@YuriGrigorov did you already sign the CLA? https://www.influxdata.com/legal/cla/
Its required for all pull requests, thanks!

sspaink added a commit that referenced this pull request Jan 4, 2021
@sjwang90
Copy link
Contributor

sjwang90 commented Jan 4, 2021

@YuriGrigorov please sign the CLA as soon as possible so we don't have to revert back the merged changes. Thanks!

@YuriGrigorov
Copy link
Contributor Author

Done. CLA signed.

masree pushed a commit to masree/telegraf that referenced this pull request Jan 5, 2021
…ta#8055)

Co-authored-by: Yuri Grigorov <jurijs.grigorovs@corp.mail.ru>
@YuriGrigorov YuriGrigorov deleted the http_idle_conn_timeout branch January 14, 2021 21:24
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
Co-authored-by: Yuri Grigorov <jurijs.grigorovs@corp.mail.ru>
(cherry picked from commit c319e63)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
…ta#8055)

Co-authored-by: Yuri Grigorov <jurijs.grigorovs@corp.mail.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants