Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix using empty string as the namespace prefix in azure_monitor output plugin #8282

Merged
merged 2 commits into from Oct 20, 2020
Merged

Fix using empty string as the namespace prefix in azure_monitor output plugin #8282

merged 2 commits into from Oct 20, 2020

Conversation

simnv
Copy link
Contributor

@simnv simnv commented Oct 17, 2020

Fixes #8256

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

@ssoroka
Copy link
Contributor

ssoroka commented Oct 19, 2020

this is awesome. Can you add a test or confirm you've tested the original scenario and that it resolves it?

@simnv
Copy link
Contributor Author

simnv commented Oct 20, 2020

@ssoroka It may be a bit overkill, but I hope I've added this test in a correct place.

@ssoroka ssoroka merged commit 1696cca into influxdata:master Oct 20, 2020
ssoroka pushed a commit that referenced this pull request Oct 20, 2020
…t plugin (#8282)

* Fix using empty string as the namespace prefix

Fixes #8256

* Test using empty string as the namespace prefix

(cherry picked from commit 1696cca)
@simnv simnv deleted the azure_monitor_empty_namespace branch August 11, 2021 20:31
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
…t plugin (influxdata#8282)

* Fix using empty string as the namespace prefix

Fixes influxdata#8256

* Test using empty string as the namespace prefix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[azure_monitor] Cannot use empty string as the nampspace prefix
2 participants