Add setting to enable caching in ipmitool #8335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-zak
reviewed
Oct 29, 2020
reimda
suggested changes
Oct 30, 2020
|
@reimda I am under the impression your requested changes marked the checks failed. Can you tell me whats wrong about it now? |
Moreover, please rebase on master. |
DEvil0000
force-pushed
the
improved_ipmitool_performance
branch
2 times, most recently
from
772154c
to
d2015d3
Compare
|
rebased and formatted as requested. Please add hacktoberfest-accepted label on merge |
|
@reimda do you still see something? |
sjwang90
added
the
feat
|
@DEvil0000 PR still needs to be rebased. |
DEvil0000
force-pushed
the
improved_ipmitool_performance
branch
from
dc0585f
to
43c5fd2
Compare
|
@zak-pawel rebase done. |
zak-pawel
suggested changes
Jan 21, 2021
reimda
approved these changes
Jan 21, 2021
zak-pawel
approved these changes
Jan 21, 2021
zak-pawel
added
the
ready for final review
reimda
changed the title
ssoroka
pushed a commit
that referenced
this pull request
Jan 27, 2021
(cherry picked from commit 358633b)
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the issue that ipmi data was reported with gaps on a 30s interval on HP G10 servers (latest firmware).
The gaps where due to the ipmitool command was not always finishing within the 20s timeout. Even changeing the timeout to 30s was not always giving it enough time to respond.
ipmi-sensors from freeipmi tools which is used in some prometheus ipmi exporters is running way faster but does not provide all information I needed.
At some point I just realized there is a cache option for ipmitool. Using this option speeds the tool up by something between 3x and 6x for most of my runs so it holds the deadline given by timeout and I can record the data not even in 30s intervals but also now in 15s intervals.
In case you merge this or agree with it, I would appreciate a hacktoberfest-accepted label.