Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue with missing metrics when pod has only pending containers #8472

Merged
merged 1 commit into from
Dec 11, 2020
Merged

Fixing issue with missing metrics when pod has only pending containers #8472

merged 1 commit into from
Dec 11, 2020

Conversation

Fiery-Fenix
Copy link
Contributor

Also added Pod Phase and Pod Reason fields
Should also fix #8347

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Fixing issue with missing metrics when pod has only pending containers
26bd678 
Also added Pod Phase and Pod Reason fields
Should also fix #8347
@Fiery-Fenix Fiery-Fenix mentioned this pull request Nov 25, 2020
Closed
@sjwang90 sjwang90 added area/k8s fix pr to fix corresponding bug labels Nov 25, 2020
srebhan
srebhan approved these changes Dec 11, 2020
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good for me but I cannot test it here.

@srebhan
Copy link
Contributor

srebhan commented Dec 11, 2020

@ssoroka or @reimda could you please give this a second look!?

@srebhan srebhan self-assigned this Dec 11, 2020
@ssoroka ssoroka merged commit 0fe2386 into influxdata:master Dec 11, 2020
@Fiery-Fenix Fiery-Fenix deleted the fix-kube_inventory-missing-metrics branch December 14, 2020 16:03
ssoroka pushed a commit that referenced this pull request Dec 16, 2020
@Fiery-Fenix @ssoroka
Fixing issue with missing metrics when pod has only pending containers (
f76ca73 
#8472)

Also added Pod Phase and Pod Reason fields
fixes #8347

Co-authored-by: Vyacheslav-Stepanov <Vyacheslav_Stepanov@epam.com>
(cherry picked from commit 0fe2386)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@Fiery-Fenix
Fixing issue with missing metrics when pod has only pending containers (
b2d0998 
influxdata#8472)

Also added Pod Phase and Pod Reason fields
fixes influxdata#8347

Co-authored-by: Vyacheslav-Stepanov <Vyacheslav_Stepanov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ssoroka ssoroka ssoroka approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/k8s fix pr to fix corresponding bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

telegraf input filter kube_inventory has bug
4 participants
@Fiery-Fenix @srebhan @ssoroka @sjwang90