Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended SNMPv3 Polling privProtocol Support #8541

Merged
merged 1 commit into from
Dec 23, 2020

Conversation

dapryor
Copy link
Contributor

@dapryor dapryor commented Dec 10, 2020

Closes #8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C. Updated the example configuration with the new privProtocols. Added the warning that those protocols are only supported if you have the appropriate tooling on your system. Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Squashed commits:
[c4e2bee] Closes influxdata#8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C.  Updated the example configuration with the new privProtocols.  Added the warning that those protocols are only supported if you have the appropriate tooling on your system.  Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.
@dapryor
Copy link
Contributor Author

dapryor commented Dec 10, 2020

The failed test is isolated from the code I have changed.

It is a failing grok test.

@sjwang90 sjwang90 added area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Dec 11, 2020
@reimda reimda added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Dec 11, 2020
@sspaink sspaink merged commit ea4feb1 into influxdata:master Dec 23, 2020
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
Squashed commits:
[c4e2bee] Closes #8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C.  Updated the example configuration with the new privProtocols.  Added the warning that those protocols are only supported if you have the appropriate tooling on your system.  Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.

(cherry picked from commit ea4feb1)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Squashed commits:
[c4e2bee] Closes influxdata#8530: Extended the internal snmp wrapper to support AES192, AES192C, AES256, and AES256C.  Updated the example configuration with the new privProtocols.  Added the warning that those protocols are only supported if you have the appropriate tooling on your system.  Added test to ensure all 4 new privProtocols could be selected and properly encrypt the priv password.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Input Plugin: SNMP - Version 3 does not support AES<blocksize>
4 participants