Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphite tags parser #8564

Merged
merged 3 commits into from
Dec 15, 2020
Merged

Conversation

hitalos
Copy link
Contributor

@hitalos hitalos commented Dec 14, 2020

Fixing #4372

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

if len(tagValue) != 2 || len(tagValue[0]) == 0 || len(tagValue[1]) == 0 {
continue
}
if strings.IndexAny(tagValue[0], "!^") != -1 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi strings.ContainsAny

@ssoroka ssoroka merged commit f6e2d45 into influxdata:master Dec 15, 2020
ssoroka pushed a commit that referenced this pull request Dec 16, 2020
(cherry picked from commit f6e2d45)
@endersonmaia
Copy link

@ssoroka hi, how to know in which version this will be released ?

@endersonmaia
Copy link

@ssoroka hi, how to know in which version this will be released ?

https://github.com/influxdata/telegraf/releases/tag/v1.17.0

@ssoroka
Copy link
Contributor

ssoroka commented Jan 5, 2021

we'll get it into 1.17.1 for you. Should be in a couple weeks. You can use the nightly build to get it until then

@endersonmaia
Copy link

we'll get it into 1.17.1 for you. Should be in a couple weeks. You can use the nightly build to get it until then

actually it's already in 1.17.0 according to the release at https://github.com/influxdata/telegraf/releases/tag/v1.17.0

right ?

@endersonmaia
Copy link

I just tested the telegraf:1.17 docker image and it's working as expected :)

@hitalos hitalos deleted the graphite-tags-parser branch January 7, 2021 01:28
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants