Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the 'measurement' json field from the particle webhook event as the measurement name, or if it's blank, use the 'name' field of the event's json. #8609

Merged
merged 1 commit into from
Jan 12, 2021
Merged

Use the 'measurement' json field from the particle webhook event as the measurement name, or if it's blank, use the 'name' field of the event's json. #8609

merged 1 commit into from
Jan 12, 2021

Conversation

ivorybilled
Copy link
Contributor

resolves #6879

@ivorybilled
Use the 'measurement' json field from the particle webhook as the mea…
83131db 
…surment name, or if it's blank, use the 'name' field of the event's json.
helenosheaa
helenosheaa reviewed Dec 21, 2020
View reviewed changes
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me

@sjwang90 sjwang90 added area/json json and json_v2 parser/serialiser related ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 12, 2021
@ivorybilled ivorybilled merged commit d9f2377 into master Jan 12, 2021
@ivorybilled ivorybilled deleted the useMeasurementNameParticleWebhooks branch January 12, 2021 22:59
ssoroka pushed a commit that referenced this pull request Jan 27, 2021
@ivorybilled @ssoroka
Use the 'measurement' json field from the particle webhook as the mea…
76ca45d 
…surment name, or if it's blank, use the 'name' field of the event's json. (#8609)

(cherry picked from commit d9f2377)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@ivorybilled
Use the 'measurement' json field from the particle webhook as the mea…
94a15e8 
…surment name, or if it's blank, use the 'name' field of the event's json. (influxdata#8609)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helenosheaa helenosheaa helenosheaa left review comments

Assignees
No one assigned
Labels
area/json json and json_v2 parser/serialiser related ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Particle.io webhook plugin wrong measurement name
3 participants
@ivorybilled @helenosheaa @sjwang90