Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to enable gzip compression in elasticsearch output #8913

Merged
merged 4 commits into from
May 8, 2021

Conversation

tuannh99
Copy link
Contributor

This adds ability to enable gzip compression in elasticsearch output.

Default is disable.

  • PUT /_template/telegraf before this PR

https://prnt.sc/107gocy

  • POST /_bulk before this PR

https://prnt.sc/107gpad

  • PUT /_template/telegraf with gzip enabled

https://prnt.sc/107gmfu

  • POST /_bulk with gzip enabled

https://prnt.sc/107gnox

Required for all PRs:

  • Associated README.md updated.
  • Has appropriate unit tests.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Feb 26, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good with one exception. Please do not modify the existing test but rather add a new one that tests gzip-compression! Both setups should be tested!

@srebhan srebhan self-assigned this Feb 26, 2021
@srebhan srebhan added area/elasticsearch plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Feb 26, 2021
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 19, 2021
@sspaink
Copy link
Contributor

sspaink commented Mar 22, 2021

@tuannh99 there were some linter errors found, would you mind resolving them? Thanks!

@srebhan
Copy link
Contributor

srebhan commented Apr 6, 2021

@tuannh99 any news here?

@tuannh99 tuannh99 force-pushed the output-elasticsearch-gzip branch from 034e442 to 3c33801 Compare May 7, 2021 11:54
@tuannh99
Copy link
Contributor Author

tuannh99 commented May 7, 2021

@srebhan I've fixed the linter. Tested changes using golangci-lint locally, it should be expressed in CI result soon.
Messed up the branch while rebasing and resolving conflicts so I had to clean it up and force push.

Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@reimda reimda merged commit b56ffdc into influxdata:master May 8, 2021
reimda pushed a commit that referenced this pull request May 20, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants