Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teamspeak input plugin query clients #8950

Merged

Conversation

JoshKeegan
Copy link
Contributor

Required for all PRs:

  • Associated README.md updated.
  • Has appropriate unit tests.

Add additional field query_clients_online to the teamspeak input plugin.
This field is useful because the clients_online field already included in the plugin is a total of both end-users and server query users connected to a virtual server, so having this allows you to break down the total clients by type.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 6, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 15, 2021
@sspaink sspaink merged commit c4a1260 into influxdata:master Mar 16, 2021
ssoroka pushed a commit that referenced this pull request Mar 17, 2021
* Add query_clients_online to the teamspeak input plugin

* Update readme for teamspeak input plugin following introduction of new query_clients_online field

(cherry picked from commit c4a1260)
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
* Add query_clients_online to the teamspeak input plugin

* Update readme for teamspeak input plugin following introduction of new query_clients_online field
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
* Add query_clients_online to the teamspeak input plugin

* Update readme for teamspeak input plugin following introduction of new query_clients_online field

(cherry picked from commit c4a1260)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants