New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the math module to the Starlark Processor #9042
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to update Starlark versions for this? I guess not if it passes. :D
Yes indeed we don't need as it has already been updated within the context of #9004 |
Required for all PRs:
resolves #8985
Motivation
The math module has been added recently to the upstream project
starlark-go
, we would like to make the Starlark processor support it tooModifications:
README.md
to refer the new exampleResult
We can use math functions in the Starlark scripts executed by the Starlark Processor.