Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the math module to the Starlark Processor #9042

Merged
merged 1 commit into from Mar 24, 2021
Merged

Add the math module to the Starlark Processor #9042

merged 1 commit into from Mar 24, 2021

Conversation

essobedo
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8985

Motivation

The math module has been added recently to the upstream project starlark-go, we would like to make the Starlark processor support it too

Modifications:

  • Adds the math module in the list of external modules to load
  • Adds a simple example showing how to use it
  • Update the README.md to refer the new example

Result

We can use math functions in the Starlark scripts executed by the Starlark Processor.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 24, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we need to update Starlark versions for this? I guess not if it passes. :D

@ssoroka ssoroka merged commit 991efd5 into influxdata:master Mar 24, 2021
@essobedo essobedo deleted the 8985/add-math-module branch March 25, 2021 08:03
@essobedo
Copy link
Contributor Author

do we need to update Starlark versions for this? I guess not if it passes. :D

Yes indeed we don't need as it has already been updated within the context of #9004

jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

processors.starlark support math module
3 participants