Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve processor.ifname startup performance #9043

Merged
merged 1 commit into from
Mar 29, 2021
Merged

Improve processor.ifname startup performance #9043

merged 1 commit into from
Mar 29, 2021

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented Mar 24, 2021 •
edited

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8801

Changed the makeTable function to only have the required field to walk.

Improvement of time telegraf --test when having only a single snmp agent was from:

real    1m12.939s
user    0m2.196s
sys     0m0.612s

To

real    0m1.526s
user    0m0.394s
sys     0m0.130s

telegraf-tiger[bot]
telegraf-tiger bot approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@Hipska Hipska added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor labels Mar 24, 2021
@Hipska Hipska changed the title Don't walk the entire interface table to just retrieve one field Improve processor.ifname performance Mar 24, 2021
@Hipska Hipska changed the title Improve processor.ifname performance Improve processor.ifname startup performance Mar 24, 2021
telegraf-tiger[bot]
telegraf-tiger bot reviewed Mar 24, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@Hipska Hipska requested a review from reimda March 25, 2021 16:59
@reimda reimda merged commit ffe92a7 into influxdata:master Mar 29, 2021
@Hipska Hipska deleted the snmp/ifname-table branch March 30, 2021 08:05
reimda pushed a commit that referenced this pull request Apr 7, 2021
@Hipska @reimda
Don't walk the entire interface table to just retrieve one field (#9043)
d82ffb7 
(cherry picked from commit ffe92a7)
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
@Hipska @jblesener
Don't walk the entire interface table to just retrieve one field (inf…
adad1f9 
…luxdata#9043)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@Hipska @reimda
Don't walk the entire interface table to just retrieve one field (inf…
5df58e5 
…luxdata#9043)

(cherry picked from commit ffe92a7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger approved these changes

@reimda reimda reimda approved these changes

@ivorybilled ivorybilled ivorybilled approved these changes

Assignees
No one assigned
Labels
area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/processor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ifName processor is walking entire table
3 participants
@Hipska @reimda @ivorybilled