inputs.nfsclient: use uint64, also update error handling #9067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 29, 2021 12:48
Fix error handling
![telegraf-tiger[bot]](https://avatars.githubusercontent.com/in/94907?s=60&v=4){kind=small}
telegraf-tiger
bot
added
the
feat
ivorybilled
approved these changes
Mar 29, 2021
ssoroka
reviewed
Mar 30, 2021
ssoroka
approved these changes
Mar 30, 2021
reimda
pushed a commit
that referenced
this pull request
Apr 7, 2021
(cherry picked from commit 071fef7)
jblesener
pushed a commit
to jblesener/telegraf
that referenced
this pull request
Apr 18, 2021
…9067) * Use uint64 Fix error handling * update comment * More detail to error
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #9028
The values received by mountstats were out of the range of int64, this pr updates the type to uint64. I couldn't find any definitive documentation that says this is the right type, but this Prometheus project that seems to do something similar also uses uint64. I added a unit test to test for the values received by @micoq (thanks!) which were out of int64 range.
Also removed the call to
log.Fatalf, having it return the error instead.