Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addresses issues in PR 4928 #9087

Merged
merged 3 commits into from Jun 1, 2021
Merged

Addresses issues in PR 4928 #9087

merged 3 commits into from Jun 1, 2021

Conversation

jessingrass
Copy link
Contributor

@jessingrass jessingrass commented Apr 2, 2021

I've added the code to allow for different formats in json_timestamp_parser.

  • Updated associated README.md.
  • Wrote appropriate unit tests. (mid-way through this process)

resolves #4928

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 2, 2021
Comment on lines 483 to 484
timestamp: "Mon Jan _2 15:04:05 2006",
expected: ansic("Mon Jan _2 15:04:05 2006"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the underscores

Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan self-assigned this Apr 19, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 1, 2021
@helenosheaa helenosheaa merged commit ad6d25a into master Jun 1, 2021
@helenosheaa helenosheaa deleted the 4928 branch June 1, 2021 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow timestamp RFC names in json parser's json_time_format
4 participants