Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to specify nanoseconds to timestamp in Starlark Processor #9105

Merged
merged 1 commit into from Apr 8, 2021
Merged

Allow to specify nanoseconds to timestamp in Starlark Processor #9105

merged 1 commit into from Apr 8, 2021

Conversation

essobedo
Copy link
Contributor

@essobedo essobedo commented Apr 8, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9104

Motivation

The upstream project starlark-go has added the support of nanoseconds in timestamp in the time module, thus the goal of this feature request is to provide the support of this new feature in the Starlark Processor.

Modifications

  • Upgrade the version of go.starlark.net
  • Add a test showing how to create a timestamp with nanoseconds
  • Refer the test into the README.md

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 8, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ssoroka ssoroka merged commit c66ccee into influxdata:master Apr 8, 2021
@essobedo essobedo deleted the 9104/support-nanos-in-timestamp branch April 8, 2021 18:57
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to specify nanoseconds to timestamp in Starlark Processor
2 participants