-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: sync nfsclient ops map in nfsclient struct #9128
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
(cherry picked from commit 1fa9259)
(cherry picked from commit 1fa9259)
Required for all PRs:
resolves #9127
Fixed an incorrect mapping inside the nfsclient plugin input.
In the
Init
function of the nfsclient plugin,nfs3Ops
andnfs4Ops
is prepared in a local map inside but never attached to the underlyingnfsclient
struct.Passing an empty map to
Result in
n.nfs3Ops[first]
orn.nfs4Ops[first]
to be false, and this branch of the code is never reached.