Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL Server - sqlServerRingBufferCPU - removed whitespaces #9130

Merged
merged 1 commit into from
May 11, 2021

Conversation

Trovalo
Copy link
Collaborator

@Trovalo Trovalo commented Apr 14, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

Removed a pair of whitespace chars from the sqlServerRingBufferCPU SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (database_type = "SQLServer")

If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 14, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@Trovalo
Copy link
Collaborator Author

Trovalo commented Apr 14, 2021

!signed-cla

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ivorybilled ivorybilled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fair enough

@Trovalo
Copy link
Collaborator Author

Trovalo commented Apr 21, 2021

@sspaink can you have a look at this and eventually merge it?

@sspaink sspaink merged commit 8b9883e into influxdata:master May 11, 2021
reimda pushed a commit that referenced this pull request May 20, 2021
### Required for all PRs:

- [ ] Updated associated README.md.
- [ ] Wrote appropriate unit tests.

Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`)

If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.

(cherry picked from commit 8b9883e)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
…#9130)

### Required for all PRs:

- [ ] Updated associated README.md.
- [ ] Wrote appropriate unit tests.

Removed a pair of whitespace chars from the **sqlServerRingBufferCPU** SQL statement and added some formatting.
This query exists only for the on-prem version of SQL Server (`database_type = "SQLServer"`)

If you were unlucky enough to have some SQL 2008 the query wouldn't work as the whitespace char is not allowed inside the statement.

(cherry picked from commit 8b9883e)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants