Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kinesis_consumer input plugin - fix repeating parser error #9169

Merged
merged 2 commits into from
May 11, 2021

Conversation

maxuntr
Copy link
Contributor

@maxuntr maxuntr commented Apr 21, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #8784

Simply log error message instead of returning it which results in the malformed data to be skipped rather than repeated

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 21, 2021
@maxuntr
Copy link
Contributor Author

maxuntr commented Apr 21, 2021

!signed_cla

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@helenosheaa
Copy link
Member

thanks for the pr! could you please run make fmt as it's currently failing on our circleci checks.

@ssoroka ssoroka merged commit 741e388 into influxdata:master May 11, 2021
reimda pushed a commit that referenced this pull request May 20, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

inputs.kinesis plugin gets stuck when receiving malformatted records
3 participants