Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate soniah/gosnmp import to gosnmp/gosnmp #9203

Merged
merged 4 commits into from
May 13, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Apr 27, 2021

This is blocking using dependabot, causing it to error out with:

Dependabot wasn't able to update github.com/soniah/gosnmp

The module path github.com/soniah/gosnmp found in your go.mod doesn't match the actual path github.com/gosnmp/gosnmp found in the dependency's go.mod.

Updating the module path in your go.mod to github.com/gosnmp/gosnmp should resolve this issue.

@sspaink sspaink requested a review from reimda April 27, 2021 18:08
Copy link
Contributor

@reimda reimda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The license check script is failing but otherwise looks good to me.

@sspaink
Copy link
Contributor Author

sspaink commented Apr 27, 2021

Versions >= 1.26.0 of the package github.com/gosnmp/gosnmp break SNMPv3 auth support causing the tests to fail.
Looks like the community is working on a fix, issue tracked here: gosnmp/gosnmp#284
Before the above issue is resolved this pull request is blocked.

@Hipska Hipska linked an issue May 5, 2021 that may be closed by this pull request
@Hipska Hipska linked an issue May 5, 2021 that may be closed by this pull request
@TimRots
Copy link

TimRots commented May 13, 2021

Versions >= 1.26.0 of the package github.com/gosnmp/gosnmp break SNMPv3 auth support causing the tests to fail.
Looks like the community is working on a fix, issue tracked here: gosnmp/gosnmp#284
Before the above issue is resolved this pull request is blocked.

@sspaink @Hipska gosnmp/gosnmp#284 is resolved in v.1.32.0 release.

@sspaink sspaink marked this pull request as ready for review May 13, 2021 19:26
@sspaink sspaink merged commit 5330a74 into influxdata:master May 13, 2021
reimda pushed a commit that referenced this pull request May 20, 2021
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update gosnmp in snmp_legacy and snmp_trap plugins SNMP Trap Inform
5 participants