Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closing all idle connections in docker input plugin #9243

Merged

Conversation

Fiery-Fenix
Copy link
Contributor

@Fiery-Fenix Fiery-Fenix commented May 5, 2021

This prevents error "too many open files" in most cases

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9242

Method Close() of official docker client just closes all idle connections and don't destroy client instance itself:
https://github.com/moby/moby/blob/17.05.x/client/client.go#L181
So it's safe to use inside telegraf input plugin

This prevents error "too many open files" in most cases
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

1 similar comment
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@Fiery-Fenix
Copy link
Contributor Author

!signed-cla

@Fiery-Fenix
Copy link
Contributor Author

Hey guys, any feedback on this small bug fix?

Copy link
Contributor

@akrantz01 akrantz01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Everything looks good to me.

@sspaink sspaink added the fix pr to fix corresponding bug label Jun 15, 2021
@sspaink sspaink merged commit 905b22c into influxdata:master Jun 15, 2021
@Fiery-Fenix Fiery-Fenix deleted the fix-docker-plugin-connections branch June 15, 2021 16:05
reimda pushed a commit that referenced this pull request Jun 17, 2021
This prevents error "too many open files" in most cases

(cherry picked from commit 905b22c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker input plugin: "too many open files" error
3 participants