Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inputs.ping: Add an option to specify packet size #9274

Merged
merged 2 commits into from May 20, 2021

Conversation

rajiv-k
Copy link
Contributor

@rajiv-k rajiv-k commented May 17, 2021

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

resolves #9222

This patch adds an option to specify the number of data bytes to be sent.
This corresponds to the "-s" in the ping(8) command.

It is only applicable for the "native" method.

This patch adds an option to specify the number of data bytes to be sent.
This corresponds to the "-s" in the ping(8) command.

It is only applicable for the "native" method.
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 17, 2021
@rajiv-k

This comment has been minimized.

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@rajiv-k
Copy link
Contributor Author

rajiv-k commented May 17, 2021

!signed-cla

@rajiv-k
Copy link
Contributor Author

rajiv-k commented May 17, 2021

Looks like an unrelated test failure to me. How do I re-run the tests?

@sspaink sspaink merged commit 8c73370 into influxdata:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an option for packet size to the ping plugin
2 participants