New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vSphere input: need to be able to configure the historical interval duration #9276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nit tests config so it will be verified to not break the config.
telegraf-tiger
bot
added
the
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
label
May 18, 2021
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Hipska
suggested changes
May 19, 2021
Hipska
added
area/vsphere
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
labels
May 19, 2021
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
Hipska
approved these changes
May 19, 2021
Hipska
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
May 19, 2021
sspaink
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/vsphere
feat
Improvement on an existing feature such as adding a new setting/mode to an existing plugin
plugin/input
1. Request for new input plugins 2. Issues/PRs that are related to input plugins
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9247
Added a configuration option "historical_interval_duration" to the vSphere configuration that defaults to 300s but can be overriden. Updated the input plugin readme to clarify that the 5min historical interval is a default but can be modified in vCenter and that queries for historical data must match the interval set in vCenter.