Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix outputs influxdb endless retires #9296

Merged
merged 21 commits into from
Jun 10, 2021

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

  • [ x ] Updated associated README.md. - no update needed
  • [ x ] Wrote appropriate unit tests. - no new unit test needed

outputs.influxdb writing to missing databases or retentions result in endless retries #9211

Fixed the repeating 404: database not found error by checking for the error and that skipping database creation is set to true in the config file and then printing an error and returning.

Fixed the repeating 500: Interal Server Error: no retention policy error by handling it as an API error.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 24, 2021
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Just a question around the location of one part of the logic.

plugins/outputs/influxdb/http.go Outdated Show resolved Hide resolved
plugins/outputs/influxdb/http.go Outdated Show resolved Hide resolved
@helenosheaa helenosheaa added fix pr to fix corresponding bug and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels May 24, 2021
@MyaLongmire MyaLongmire self-assigned this Jun 10, 2021
@sspaink sspaink merged commit da7f2c7 into master Jun 10, 2021
@sspaink sspaink deleted the bugfix-outputs-influxdb-endless-retires branch June 10, 2021 21:05
reimda pushed a commit that referenced this pull request Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

outputs.influxdb writing to missing databases or retentions result in endless retries
3 participants