upgrade denisenkom go-mssql to v0.10.0 #9358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the pull request! |
|
!signed-cla |
srebhan
added
the
ready for final review
sspaink
approved these changes
Jun 14, 2021
There was a problem hiding this comment.
@unitmatrix thanks for updating the package! Do you think you could rebase the latest master into your pull request? We just moved to using the Go version 1.16.5 and it would be nice to see the CI run again using the latest version of Go to make sure everything is still in order. Thanks!
added 2 commits
June 15, 2021 17:28
|
!retry-failed |
|
rebased onto master to run using Go 1.16.5 |
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
pushed a commit
that referenced
this pull request
Jun 17, 2021
(cherry picked from commit 55fa78c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9266
go-mssql v0.10.0 fixes issues with tls changes in Go 1.16 causing panic crash in windows telegraf v1.18.2, v1.18.3 sqlserver plugin