Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated signalfx #9375

Merged
merged 3 commits into from Jun 22, 2021
Merged

updated signalfx #9375

merged 3 commits into from Jun 22, 2021

Conversation

MyaLongmire
Copy link
Contributor

@MyaLongmire MyaLongmire commented Jun 15, 2021 •
edited by reimda

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.

updated jaeger to v1.23.0 broke all calls to thrift. so updated all instances of signalfx instead.

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 15, 2021
@MyaLongmire MyaLongmire changed the title updated jaeger to v1.23.0 updated signalfx Jun 15, 2021
@telegraf-tiger
Copy link
Contributor

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

@MyaLongmire MyaLongmire marked this pull request as ready for review June 15, 2021 19:21
srebhan
srebhan approved these changes Jun 18, 2021
View reviewed changes
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with all tests passing. Thanks for looking into this!

@srebhan srebhan self-assigned this Jun 18, 2021
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 18, 2021
@sspaink sspaink added dependencies Pull requests that update a dependency file and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Jun 22, 2021
@sspaink sspaink merged commit 812fbd6 into master Jun 22, 2021
@sspaink sspaink deleted the jaeger-dependancy-update branch June 22, 2021 16:54
reimda pushed a commit that referenced this pull request Jul 7, 2021
@MyaLongmire @reimda
Update signalfx to v3.3.0->v3.3.34 (#9375)
a21c212 
(cherry picked from commit 812fbd6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sspaink sspaink sspaink approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
dependencies Pull requests that update a dependency file ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MyaLongmire @sspaink @srebhan