Add sysstat plugin #939
Add sysstat plugin #939
Conversation
|
circleci failed because of: This is probably not because of my plugin. |
|
I'll kick a rebuild |
|
thanks for the contribution @zbindenren, but I think there might be a better way to handle the collection interval. You could, for instance, cache the timestamp of the previous call to |
|
@sparrc I made the requested changes. Let me know what you think. |
| ## and represents itself a measurement. | ||
| ## | ||
| ## If Group is true, corresponding metrics are grouped to a single measurement. | ||
| # group = false |
There was a problem hiding this comment.
I would prefer group=true by default, because this is more consistent with the rest of telegraf
There was a problem hiding this comment.
done with 7256f3e
|
@zbindenren I'm getting this error running on ubuntu 14.04 & centos 6.7: configuration is default, except |
| ## Activities is a list of activities, that are passed as argument to the | ||
| ## sadc collector utility (e.g: DISK, SNMP etc...) | ||
| ## The more activities that are added, the more data is collected. | ||
| # activities = ["DISK"] |
There was a problem hiding this comment.
this should be uncommented by default? since the option below is uncommented by default
There was a problem hiding this comment.
sadc_path is commented because I did not define a default value in the code. I can set the Ubuntu default value if you want, then I can comment out the value.
… if less in collect() method
| Group: true, | ||
| Activities: dfltActivities, | ||
| } | ||
| sadf, _ := exec.LookPath("sadf") |
There was a problem hiding this comment.
why did you do this? I think this will look at the sadf path in the build system, but we want to look at the path on the runtime system nevermind, I'm wrong
|
@sparrc I made the changes. The error you got, was because I used an sadf option ( |
Add sysstat plugin.