Fix schema mess-up for x509 with https #9400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tested in Linux, using: [[inputs.x509_cert]]
sources = ["https://popey.com:443"]Worked as expected. 1 alan@ac:~/Apps/telegraf/telegraf-1.19.0$ /tmp/telegraf-1.19.0/usr/bin/telegraf --debug --test --config ./etc/telegraf/telegraf.conf
2021-06-21T13:59:37Z I! Starting Telegraf
2021-06-21T13:59:37Z D! [agent] Initializing plugins
2021-06-21T13:59:37Z D! [agent] Starting service inputs
2021-06-21T13:59:37Z D! [agent] Stopping service inputs
2021-06-21T13:59:37Z D! [agent] Input channel closed
2021-06-21T13:59:37Z D! [agent] Stopped Successfully
> x509_cert,common_name=popey.com,host=ac,issuer_common_name=R3,public_key_algorithm=RSA,san=popey.com,serial_number=475269a602750dccbf81f0efd750705d774,signature_algorithm=SHA256-RSA,source=https://popey.com:443,verification=valid age=5026146i,enddate=1627033831i,expiry=2749853i,startdate=1619257831i,verification_code=0i 1624283977000000000
> x509_cert,common_name=R3,country=US,host=ac,issuer_common_name=DST\ Root\ CA\ X3,organization=Let's\ Encrypt,public_key_algorithm=RSA,serial_number=400175048314a4c8218c84a90c16cddf,signature_algorithm=SHA256-RSA,source=https://popey.com:443,verification=valid age=22185477i,enddate=1632943300i,expiry=8659322i,startdate=1602098500i,verification_code=0i 1624283977000000000 |
sspaink
approved these changes
Jun 22, 2021
srebhan
force-pushed
the
x509_fix_schema_mixup
branch
from
56024a5
to
cc88d7b
Compare
srebhan
force-pushed
the
x509_fix_schema_mixup
branch
from
cc88d7b
to
eaefc6a
Compare
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
reimda
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit d63a701)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
When using the x509_cert plugin with
httpssources, thesourcetag should contain the specified source. However, in #6952 we messed up that tag by unintentionally changing the scheme of the source totcpforhttpssources as described in #9384. The present PR fixes this issue by not messing with the scheme directly.Please note: This PR is based on and should be merged after #9289!
resolves #9384