Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tags no longer required in included_keys #9406

Merged
merged 1 commit into from Jun 22, 2021
Merged

Conversation

MyaLongmire
Copy link
Contributor

Required for all PRs:

  • Updated associated README.md. - no needed to be updated
  • Wrote appropriate unit tests. - fixed test data so tags is no longer included in included_keys

resolves #9394

added a line to append tags to included keys
took tags out of included_keys in test data

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 21, 2021
Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@sspaink sspaink merged commit 8638a41 into master Jun 22, 2021
@sspaink sspaink deleted the json-v2-tags-included-keys branch June 22, 2021 16:48
reimda pushed a commit that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin
Projects
None yet
Development

Successfully merging this pull request may close these issues.

json_v2: tags required to be listed as included_keys
2 participants