Don't stop parsing after statsd parsing error #9423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks so much for the pull request! |
|
!signed-cla |
sspaink
approved these changes
Jun 23, 2021
sspaink
added
the
ready for final review
reimda
pushed a commit
that referenced
this pull request
Jul 7, 2021
(cherry picked from commit c6c3efd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
I marked off the two above criteria because I don't believe this requires a README.md update and I don't think reliable unit tests will be easy to implement since
Statsd.parser()doesn't provide negative feedback upon a parser error anymore. I'm open to other ways to solve this though!resolves #9422
This fixes an issue where statsd stats would stop getting processed because malformed stats would cause the parser to return. Malformed stats should be logged but they shouldn't cause parsing to stop.