New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix nil pointer error in knx_listener #9444
Conversation
Thanks so much for the pull request! |
!signed-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for tracking this down!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the linter issue with the empty line at beginning of TestRegularReceives_MultipleMessages()
.
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
(cherry picked from commit 9b22161)
Required for all PRs:
(Don't think this is necessary but happy to make any changes if required)
The KNX input plugin crashes with a nil pointer dereference error when receiving subsequent messages for an ignored group address:
I narrowed it down to a faulty boolean check which makes it still try to process an ignored KNX message. The included unit test fails without the changes made.