Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error returned to OpenTelemetry client #9797

Merged
merged 2 commits into from
Sep 23, 2021
Merged

fix: error returned to OpenTelemetry client #9797

merged 2 commits into from
Sep 23, 2021

Conversation

jacobmarble
Copy link
Member

The OpenTelemetry input plugin gRPC service returns the following error
to every metrics write request (this does not happen to trace or log
requests):

rpc error: code = Internal desc = grpc: error while marshaling: proto: Marshal called with nil

The solution was a single line of code, just set a pointer to an empty struct. Writing a regression test? 90 SLOC.

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

The OpenTelemetry input plugin gRPC service returns the following error
to every metrics write request (this does not happen to trace or log
requests):

rpc error: code = Internal desc = grpc: error while marshaling: proto: Marshal called with nil

The solution was a single line of code, just set a pointer to an empty struct. Writing a regression test? 90 SLOC.
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Sep 22, 2021
@jacobmarble
Copy link
Member Author

@sjwang90 please queue this bugfix for 1.20.1

@sjwang90 sjwang90 added the area/telemetry All about OpenTelemetry and other telemetry variants label Sep 22, 2021
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 22, 2021
Copy link
Contributor

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@MyaLongmire MyaLongmire merged commit fb088bd into influxdata:master Sep 23, 2021
reimda pushed a commit that referenced this pull request Oct 6, 2021
@jacobmarble jacobmarble deleted the jgm-inputs-opentelemetry-grpc-service branch October 27, 2021 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/telemetry All about OpenTelemetry and other telemetry variants fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants