Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add custom time/date format field for elasticsearch_query #9838

Merged

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Sep 29, 2021

This adds the ability to specify a custom time/date format to
elasticsearch queries. Elasticsearch has a large number of built-in
date/time formats, however, users are also able to add in a custom
date/time format as well. If this is the case, then the query will
always fail as it will be unable to parse the date/time.

This field is generally not required if a user is using a
standard/built-in type.

Required for all PRs:

  • Updated associated README.md.
  • Wrote appropriate unit tests.
  • Pull request title or commits are in conventional commit format (e.g. feat: or fix:)

This adds the ability to specify a custom time/date format to
elasticsearch queries. Elasticsearch has a large number of built in
date/time formats, however users are also able to add in a custom
date/time format as well. If this is the case, then the query will
always fail as it will be unable to parse the date/time.

This field is generally not required if a user is using a
standard/built-in type.
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 29, 2021
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 30, 2021
@powersj powersj requested a review from reimda October 1, 2021 14:47
Copy link
Member

@helenosheaa helenosheaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sspaink sspaink merged commit 014161c into influxdata:master Oct 5, 2021
etycomputer pushed a commit to etycomputer/telegraf that referenced this pull request Oct 6, 2021
reimda pushed a commit that referenced this pull request Oct 6, 2021
@powersj powersj deleted the feat/elasticsearch-add-date-format branch January 23, 2022 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants