fix: mongodb input plugin issue #9845 #9846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
input plugin would fail (and result in seg fault) because there was no check to see if newStat.Metrics.Repl.Network.GetMores was nil or not. Added a checking so that the assignment would happen only when newStat.Metrics.Repl.Network.GetMores is not nil. ### Required for all PRs: <!-- Complete the tasks in the following list. Change [ ] to [x] to show completion. --> - [ ] Updated associated README.md. - [ ] Wrote appropriate unit tests. - [x] Pull request title or commits are in [conventional commit format](https://www.conventionalcommits.org/en/v1.0.0/#summary) (e.g. feat: or fix:) <!-- Link to issues that describe the need for the change. Issues should include context that will help reviewers understand why the change is needed. Make sure to link issues and using a keyword like "resolves influxdata#1234". https://docs.github.com/en/github/managing-your-work-on-github/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword --> resolves influxdata#9845 <!-- Finally, include a summary of the code change itself. This description should tell reviewers how the issues were resolved. example: Added an input plugin to gather yak shaving metrics using golang library yaktech/shaver. --> This code change will make sure to check the newStat.Metrics.Repl.Network.GetMores is not null, before performing any access to its underlying variables. This will prevent the mongodb plugin from resulting into segmentation violation that the issue influxdata#9845 reported. ``` if newStat.Metrics.Repl.Network.GetMores != nil { returnVal.ReplNetworkGetmoresNum = newStat.Metrics.Repl.Network.GetMores.Num returnVal.ReplNetworkGetmoresTotalMillis = newStat.Metrics.Repl.Network.GetMores.TotalMillis } ```
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
the
feat
|
!signed-cla |
format fixes
howardyoo
commented
Oct 1, 2021
Looks like new artifacts were built from this PR. Get them here!Artifact URLs |
helenosheaa
added
the
ready for final review
reimda
pushed a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
input plugin would fail (and result in seg fault) because there was no check to see if newStat.Metrics.Repl.Network.GetMores was nil or not. Added a checking so that the assignment would happen only when newStat.Metrics.Repl.Network.GetMores is not nil.
Required for all PRs:
resolves #9845
This code change will make sure to check the newStat.Metrics.Repl.Network.GetMores is not null, before performing any access to its underlying variables. This will prevent the mongodb plugin from resulting into segmentation violation that the issue #9845 reported.