Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds the ability to create and name a tag containing the filename using the directory monitor input plugin #9860

Conversation

etycomputer
Copy link
Contributor

@etycomputer etycomputer commented Oct 5, 2021

✨ Added the ability to create and name a tag containing the filename of the file parsed using the directory monitor input plugin. Leaving this option blank will cause the tag not to be generated.

✅ Added tests for the newly added feature.

Required for all PRs:

resolves #

…of the file parsed using the directory monitor input plugin. Leaving this option blank will cause the tag not to be generated.

✅ Added tests for the newly added feature.
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 5, 2021
@etycomputer etycomputer changed the title Adds the ability to create and name a tag containing the filename using the directory monitor input plugin feat: Adds the ability to create and name a tag containing the filename using the directory monitor input plugin Oct 5, 2021
@etycomputer
Copy link
Contributor Author

!signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@etycomputer
Copy link
Contributor Author

InfluxData Contributor License Agreement has been signed !signed-cla

@powersj
Copy link
Contributor

powersj commented Oct 5, 2021

!signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 5, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@etycomputer
Copy link
Contributor Author

!signed-cla

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 6, 2021

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@etycomputer
Copy link
Contributor Author

🤝 ✒️ The CLA has been signed !signed-cla

@etycomputer
Copy link
Contributor Author

!signed-cla

Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with the changes! I'll mark this ready for final review. Thanks again

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 6, 2021
@sspaink sspaink merged commit d06b387 into influxdata:master Oct 7, 2021
@etycomputer etycomputer deleted the add-file-tag-to-directory-monitor-inputs branch October 11, 2021 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants