Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input/prometheus): move err check to correct place #9920

Merged
merged 1 commit into from
Oct 13, 2021
Merged

fix(input/prometheus): move err check to correct place #9920

merged 1 commit into from
Oct 13, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Oct 13, 2021

The error returned by http.NewRequest was checked after using the returned request which could be nil.

@sspaink sspaink added fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Oct 13, 2021
@telegraf-tiger
Copy link
Contributor

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm freebsd_amd64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_armv7.tar.gz
armhf.deb i386.rpm freebsd_i386.tar.gz
i386.deb ppc64le.rpm linux_amd64.tar.gz
mips.deb s390x.rpm linux_arm64.tar.gz
mipsel.deb x86_64.rpm linux_armel.tar.gz
ppc64el.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

@sspaink sspaink merged commit 432b30d into master Oct 13, 2021
@sspaink sspaink deleted the moveerrork8 branch October 13, 2021 19:43
powersj pushed a commit that referenced this pull request Oct 27, 2021
@sspaink @powersj
fix(input/prometheus): move err check to correct place (#9920)
2e3bfb9 
(cherry picked from commit 432b30d)
VladislavSenkevich pushed a commit to gwos/telegraf that referenced this pull request Nov 23, 2021
@sspaink
fix(input/prometheus): move err check to correct place (influxdata#9920)
b2d7d0d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powersj powersj powersj approved these changes

Assignees
No one assigned
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sspaink @powersj