Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Linter fixes for plugins/inputs/[k-l]* #9999

Merged
merged 1 commit into from
Oct 27, 2021
Merged

fix: Linter fixes for plugins/inputs/[k-l]* #9999

merged 1 commit into from
Oct 27, 2021

Conversation

zak-pawel
Copy link
Collaborator

Following findings were fixed:

plugins/inputs/kafka_consumer/kafka_consumer.go:6:2                                  revive       imports-blacklist: should not use the following blacklisted import: "log"
plugins/inputs/kafka_consumer/kafka_consumer_test.go:282:17                          errcheck     Error return value of `cg.ConsumeClaim` is not checked
plugins/inputs/kafka_consumer_legacy/kafka_consumer_legacy_integration_test.go:87:2  gosimple     S1000: should use for range instead of for { select {} }
plugins/inputs/kube_inventory/kube_state.go:190:2                                    revive       import-shadowing: The name 'filter' shadows an import name
plugins/inputs/kube_inventory/kube_state.go:6:2                                      revive       imports-blacklist: should not use the following blacklisted import: "log"
plugins/inputs/kube_inventory/node.go:28:51                                          revive       empty-lines: extra empty line at the start of a block
plugins/inputs/lanz/lanz.go:88:2                                                     gosimple     S1000: should use for range instead of for { select {} }
plugins/inputs/lanz/lanz_test.go:9:2                                                 staticcheck  SA1019: package github.com/golang/protobuf/proto is deprecated: Use the "google.golang.org/protobuf/proto" package instead. 
plugins/inputs/logstash/logstash.go:182:42                                           revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/logstash/logstash.go:221:42                                           revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/logstash/logstash.go:247:46                                           revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/logstash/logstash.go:406:47                                           revive       import-shadowing: The name 'url' shadows an import name
plugins/inputs/logstash/logstash.go:450:48                                           revive       import-shadowing: The name 'url' shadows an import name

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 26, 2021
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 26, 2021
@MyaLongmire MyaLongmire merged commit eec6fd5 into influxdata:master Oct 27, 2021
powersj pushed a commit that referenced this pull request Nov 17, 2021
VladislavSenkevich pushed a commit to gwos/telegraf that referenced this pull request Nov 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants