Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update rudder stack version #6877

Merged
merged 2 commits into from
Mar 25, 2024
Merged

Conversation

david-rusnak
Copy link
Contributor

@david-rusnak david-rusnak commented Mar 22, 2024

Part of https://github.com/influxdata/quartz/issues/7619

Temporarily pins rudder stack version to 2.48.2 to bypass monitor-ci error. We should unpin this version once rudder stack is fixed.

Checklist

Authors and Reviewer(s), please verify the following:

  • A PR description, regardless of the triviality of this change, that communicates the value of this PR
  • Well-formatted conventional commit messages that provide context into the change
  • Documentation updated or issue created (provide link to issue/PR)
  • Signed CLA (if not already signed)
  • Feature flagged, if applicable

Co-authored-by: Bill O'Connell <91283923+wdoconnell@users.noreply.github.com>
@david-rusnak david-rusnak requested a review from a team as a code owner March 22, 2024 17:11
@david-rusnak david-rusnak changed the title Update rudder stack version fix: update rudder stack version Mar 22, 2024
@wdoconnell
Copy link
Contributor

For context: the underlying issue is that the latest version of rudderstack-sdk-js (and the older version, which we were on) don't specify a valid version of rudderstack/analytics-js-common.

Copy link
Contributor

@wdoconnell wdoconnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good based on our pairing.

@david-rusnak david-rusnak added this pull request to the merge queue Mar 22, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 22, 2024
@david-rusnak david-rusnak added this pull request to the merge queue Mar 25, 2024
Merged via the queue into master with commit 8488f24 Mar 25, 2024
11 checks passed
@david-rusnak david-rusnak deleted the update-rudder-stack-version branch March 25, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants