-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backends): consul cloud discovery and go modules #22
Conversation
cc @fntlnz |
@marcotuna thank you for contributing to Wirey! Do you mind splitting the migration to Go modules into it's own PR and updating the CI steps to include the install of bzr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding to the backends!
@marcotuna if you could, please fill out our CLA |
Hello @BondAnthony I've submited the CLA. About the issues you pointed, I will take a look and change it in order to be compliant with Influx requirements as soon as I get some free time. |
@BondAnthony about the separation of this PR with Go modules, how do you suggest doing it? Or, is it really needed? The issue about the bzr dependency is gone, it was due to a lot of junk on my go.mod file, I cleaned it up |
Great thank you, that cleanup should be good so you can ignore my comment. Thanks |
@BondAnthony, since this commits are a few months old and new the "Semantic Pull Request" is only here recently, is it possible to merge this PR and from now on the next PR's will be more organized and will follow the semantic convention, is it possible? Because there are too many changes and now it's hard to get that changed into different PR's. I would like to contribute with more improvements but I would like to see this going further. |
@marcotuna sorry for the delay yes we can take care of the semantic check. I'm validating no major issues with this change. Thank you again for opening the PR. |
This patch enables:
Usage example using go-sockaddr:
wirey --endpoint '{{GetInterfaceIP "wlp2s0"}}' --ipaddr 192.168.40.99 --consul '{{GetInterfaceIP "tun0"}}' --endpoint-port 5555
Usage example using go-discover
wirey --endpoint 192.168.33.11 --ipaddr 172.30.0.4 --consul 192.168.33.10 --endpoint-port 5555 --discover "provider=scaleway organization=ORGANIZATION_ID tag_name=consul token=TOKEN_ID region=par1