-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace failure with thiserror #70
Merged
Empty2k12
merged 1 commit into
influxdb-rs:master
from
msrd0:replace-failure-with-thiserror
Oct 3, 2020
Merged
Replace failure with thiserror #70
Empty2k12
merged 1 commit into
influxdb-rs:master
from
msrd0:replace-failure-with-thiserror
Oct 3, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for this PR! |
little-dude
added a commit
to xaynetwork/xaynet
that referenced
this pull request
Nov 19, 2020
rusoto depends on time 0.2.22 for which a CVE exists: GHSA-wcg3-cvx6-7396 `cargo-audit` still spits a few warnings ### `dirs` 2.0.2 ``` Crate: dirs Version: 2.0.2 Warning: unmaintained Title: dirs is unmaintained, use dirs-next instead Date: 2020-10-16 ID: RUSTSEC-2020-0053 URL: https://rustsec.org/advisories/RUSTSEC-2020-0053 Dependency tree: dirs 2.0.2 └── rusoto_credential 0.45.0 ├── rusoto_signature 0.45.0 │ └── rusoto_core 0.45.0 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ └── rusoto_s3 0.45.0 │ └── xaynet-server 0.1.0 └── rusoto_core 0.45.0 ``` This should be fixed by rusoto/rusoto#1846 ### `failure` 0.1.8 ``` Crate: failure Version: 0.1.8 Warning: unmaintained Title: failure is officially deprecated/unmaintained Date: 2020-05-02 ID: RUSTSEC-2020-0036 URL: https://rustsec.org/advisories/RUSTSEC-2020-0036 Dependency tree: failure 0.1.8 └── influxdb 0.1.0 └── xaynet-server 0.1.0 └── xaynet 0.10.0 ``` It is fixed in `influxdb` 0.2: influxdb-rs/influxdb-rust#70. We should upgrade. ### `net2` Much more tricky. This comes from `tokio` 0.2, which we heavily depends on, both explicitely and transitively. This is going to take time, but at the same time, there's not real emergency. Crate: net2 Version: 0.2.35 Warning: unmaintained Title: `net2` crate has been deprecated; use `socket2` instead Date: 2020-05-01 ID: RUSTSEC-2020-0016 URL: https://rustsec.org/advisories/RUSTSEC-2020-0016 Dependency tree: net2 0.2.35 ├── miow 0.2.1 └── mio 0.6.22 ├── tokio 0.2.23 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ ├── xaynet-sdk 0.1.0 │ │ ├── xaynet-mobile 0.0.0 │ │ ├── xaynet 0.10.0 │ │ └── examples 0.0.0 │ ├── xaynet-mobile 0.0.0 │ ├── warp 0.2.5 │ │ └── xaynet-server 0.1.0 │ ├── tower-timeout 0.3.0 │ │ └── tower 0.3.1 │ │ └── xaynet-server 0.1.0 │ ├── tower-test 0.3.0 │ │ └── xaynet-server 0.1.0 │ ├── tower-retry 0.3.0 │ │ └── tower 0.3.1 │ ├── tower-load 0.3.0 │ │ └── tower-limit 0.3.1 │ │ └── tower 0.3.1 │ ├── tower-limit 0.3.1 │ ├── tower-buffer 0.3.0 │ │ └── tower 0.3.1 │ ├── tokio-util 0.3.1 │ │ ├── redis 0.17.0 │ │ │ └── xaynet-server 0.1.0 │ │ └── h2 0.2.7 │ │ └── hyper 0.13.9 │ │ ├── warp 0.2.5 │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ │ ├── xaynet-server 0.1.0 │ │ │ └── rusoto_s3 0.45.0 │ │ │ └── xaynet-server 0.1.0 │ │ ├── rusoto_credential 0.45.0 │ │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ ├── rusoto_core 0.45.0 │ │ ├── reqwest 0.10.8 │ │ │ ├── xaynet-sdk 0.1.0 │ │ │ ├── influxdb 0.1.0 │ │ │ │ └── xaynet-server 0.1.0 │ │ │ └── examples 0.0.0 │ │ ├── hyper-tls 0.4.3 │ │ │ ├── rusoto_core 0.45.0 │ │ │ └── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ │ └── reqwest 0.10.8 │ ├── tokio-tungstenite 0.11.0 │ │ └── warp 0.2.5 │ ├── tokio-tls 0.3.1 │ │ ├── reqwest 0.10.8 │ │ └── hyper-tls 0.4.3 │ ├── tokio-test 0.2.1 │ │ ├── xaynet-server 0.1.0 │ │ ├── xaynet-sdk 0.1.0 │ │ └── tower-test 0.3.0 │ ├── tokio-rustls 0.14.1 │ │ ├── warp 0.2.5 │ │ ├── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ ├── rusoto_signature 0.45.0 │ ├── rusoto_credential 0.45.0 │ ├── rusoto_core 0.45.0 │ ├── reqwest 0.10.8 │ ├── redis 0.17.0 │ ├── hyper-tls 0.4.3 │ ├── hyper-rustls 0.21.0 │ ├── hyper 0.13.9 │ ├── h2 0.2.7 │ ├── examples 0.0.0 │ └── combine 4.4.0 │ └── redis 0.17.0 ├── mio-uds 0.6.8 │ └── tokio 0.2.23 └── mio-named-pipes 0.1.7 └── tokio 0.2.23 ``` ### `stdweb` 0.4.20 ``` Crate: stdweb Version: 0.4.20 Warning: unmaintained Title: stdweb is unmaintained Date: 2020-05-04 ID: RUSTSEC-2020-0056 URL: https://rustsec.org/advisories/RUSTSEC-2020-0056 Dependency tree: stdweb 0.4.20 └── time 0.2.23 ``` This is fixed in `time` 0.3, which hasn't been released yet. I don't think we depend on it anyway, because this is an optional dependency for webassembly.
little-dude
added a commit
to xaynetwork/xaynet
that referenced
this pull request
Nov 19, 2020
rusoto depends on time 0.2.22 for which a CVE exists: GHSA-wcg3-cvx6-7396 `cargo-audit` still spits a few warnings ### `dirs` 2.0.2 ``` Crate: dirs Version: 2.0.2 Warning: unmaintained Title: dirs is unmaintained, use dirs-next instead Date: 2020-10-16 ID: RUSTSEC-2020-0053 URL: https://rustsec.org/advisories/RUSTSEC-2020-0053 Dependency tree: dirs 2.0.2 └── rusoto_credential 0.45.0 ├── rusoto_signature 0.45.0 │ └── rusoto_core 0.45.0 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ └── rusoto_s3 0.45.0 │ └── xaynet-server 0.1.0 └── rusoto_core 0.45.0 ``` This should be fixed by rusoto/rusoto#1846 ### `failure` 0.1.8 ``` Crate: failure Version: 0.1.8 Warning: unmaintained Title: failure is officially deprecated/unmaintained Date: 2020-05-02 ID: RUSTSEC-2020-0036 URL: https://rustsec.org/advisories/RUSTSEC-2020-0036 Dependency tree: failure 0.1.8 └── influxdb 0.1.0 └── xaynet-server 0.1.0 └── xaynet 0.10.0 ``` It is fixed in `influxdb` 0.2: influxdb-rs/influxdb-rust#70. We should upgrade. ### `net2` Much more tricky. This comes from `tokio` 0.2, which we heavily depends on, both explicitely and transitively. This is going to take time, but at the same time, there's not real emergency. Crate: net2 Version: 0.2.35 Warning: unmaintained Title: `net2` crate has been deprecated; use `socket2` instead Date: 2020-05-01 ID: RUSTSEC-2020-0016 URL: https://rustsec.org/advisories/RUSTSEC-2020-0016 Dependency tree: net2 0.2.35 ├── miow 0.2.1 └── mio 0.6.22 ├── tokio 0.2.23 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ ├── xaynet-sdk 0.1.0 │ │ ├── xaynet-mobile 0.0.0 │ │ ├── xaynet 0.10.0 │ │ └── examples 0.0.0 │ ├── xaynet-mobile 0.0.0 │ ├── warp 0.2.5 │ │ └── xaynet-server 0.1.0 │ ├── tower-timeout 0.3.0 │ │ └── tower 0.3.1 │ │ └── xaynet-server 0.1.0 │ ├── tower-test 0.3.0 │ │ └── xaynet-server 0.1.0 │ ├── tower-retry 0.3.0 │ │ └── tower 0.3.1 │ ├── tower-load 0.3.0 │ │ └── tower-limit 0.3.1 │ │ └── tower 0.3.1 │ ├── tower-limit 0.3.1 │ ├── tower-buffer 0.3.0 │ │ └── tower 0.3.1 │ ├── tokio-util 0.3.1 │ │ ├── redis 0.17.0 │ │ │ └── xaynet-server 0.1.0 │ │ └── h2 0.2.7 │ │ └── hyper 0.13.9 │ │ ├── warp 0.2.5 │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ │ ├── xaynet-server 0.1.0 │ │ │ └── rusoto_s3 0.45.0 │ │ │ └── xaynet-server 0.1.0 │ │ ├── rusoto_credential 0.45.0 │ │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ ├── rusoto_core 0.45.0 │ │ ├── reqwest 0.10.8 │ │ │ ├── xaynet-sdk 0.1.0 │ │ │ ├── influxdb 0.1.0 │ │ │ │ └── xaynet-server 0.1.0 │ │ │ └── examples 0.0.0 │ │ ├── hyper-tls 0.4.3 │ │ │ ├── rusoto_core 0.45.0 │ │ │ └── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ │ └── reqwest 0.10.8 │ ├── tokio-tungstenite 0.11.0 │ │ └── warp 0.2.5 │ ├── tokio-tls 0.3.1 │ │ ├── reqwest 0.10.8 │ │ └── hyper-tls 0.4.3 │ ├── tokio-test 0.2.1 │ │ ├── xaynet-server 0.1.0 │ │ ├── xaynet-sdk 0.1.0 │ │ └── tower-test 0.3.0 │ ├── tokio-rustls 0.14.1 │ │ ├── warp 0.2.5 │ │ ├── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ ├── rusoto_signature 0.45.0 │ ├── rusoto_credential 0.45.0 │ ├── rusoto_core 0.45.0 │ ├── reqwest 0.10.8 │ ├── redis 0.17.0 │ ├── hyper-tls 0.4.3 │ ├── hyper-rustls 0.21.0 │ ├── hyper 0.13.9 │ ├── h2 0.2.7 │ ├── examples 0.0.0 │ └── combine 4.4.0 │ └── redis 0.17.0 ├── mio-uds 0.6.8 │ └── tokio 0.2.23 └── mio-named-pipes 0.1.7 └── tokio 0.2.23 ``` ### `stdweb` 0.4.20 ``` Crate: stdweb Version: 0.4.20 Warning: unmaintained Title: stdweb is unmaintained Date: 2020-05-04 ID: RUSTSEC-2020-0056 URL: https://rustsec.org/advisories/RUSTSEC-2020-0056 Dependency tree: stdweb 0.4.20 └── time 0.2.23 ``` This is fixed in `time` 0.3, which hasn't been released yet. I don't think we depend on it anyway, because this is an optional dependency for webassembly.
little-dude
added a commit
to xaynetwork/xaynet
that referenced
this pull request
Nov 19, 2020
rusoto depends on time 0.2.22 for which a CVE exists: GHSA-wcg3-cvx6-7396 `cargo-audit` still spits a few warnings ### `dirs` 2.0.2 ``` Crate: dirs Version: 2.0.2 Warning: unmaintained Title: dirs is unmaintained, use dirs-next instead Date: 2020-10-16 ID: RUSTSEC-2020-0053 URL: https://rustsec.org/advisories/RUSTSEC-2020-0053 Dependency tree: dirs 2.0.2 └── rusoto_credential 0.45.0 ├── rusoto_signature 0.45.0 │ └── rusoto_core 0.45.0 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ └── rusoto_s3 0.45.0 │ └── xaynet-server 0.1.0 └── rusoto_core 0.45.0 ``` This should be fixed by rusoto/rusoto#1846 ### `failure` 0.1.8 ``` Crate: failure Version: 0.1.8 Warning: unmaintained Title: failure is officially deprecated/unmaintained Date: 2020-05-02 ID: RUSTSEC-2020-0036 URL: https://rustsec.org/advisories/RUSTSEC-2020-0036 Dependency tree: failure 0.1.8 └── influxdb 0.1.0 └── xaynet-server 0.1.0 └── xaynet 0.10.0 ``` It is fixed in `influxdb` 0.2: influxdb-rs/influxdb-rust#70. We should upgrade. ### `net2` Much more tricky. This comes from `tokio` 0.2, which we heavily depends on, both explicitely and transitively. This is going to take time, but at the same time, there's not real emergency. ``` Crate: net2 Version: 0.2.35 Warning: unmaintained Title: `net2` crate has been deprecated; use `socket2` instead Date: 2020-05-01 ID: RUSTSEC-2020-0016 URL: https://rustsec.org/advisories/RUSTSEC-2020-0016 Dependency tree: net2 0.2.35 ├── miow 0.2.1 └── mio 0.6.22 ├── tokio 0.2.23 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ ├── xaynet-sdk 0.1.0 │ │ ├── xaynet-mobile 0.0.0 │ │ ├── xaynet 0.10.0 │ │ └── examples 0.0.0 │ ├── xaynet-mobile 0.0.0 │ ├── warp 0.2.5 │ │ └── xaynet-server 0.1.0 │ ├── tower-timeout 0.3.0 │ │ └── tower 0.3.1 │ │ └── xaynet-server 0.1.0 │ ├── tower-test 0.3.0 │ │ └── xaynet-server 0.1.0 │ ├── tower-retry 0.3.0 │ │ └── tower 0.3.1 │ ├── tower-load 0.3.0 │ │ └── tower-limit 0.3.1 │ │ └── tower 0.3.1 │ ├── tower-limit 0.3.1 │ ├── tower-buffer 0.3.0 │ │ └── tower 0.3.1 │ ├── tokio-util 0.3.1 │ │ ├── redis 0.17.0 │ │ │ └── xaynet-server 0.1.0 │ │ └── h2 0.2.7 │ │ └── hyper 0.13.9 │ │ ├── warp 0.2.5 │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ │ ├── xaynet-server 0.1.0 │ │ │ └── rusoto_s3 0.45.0 │ │ │ └── xaynet-server 0.1.0 │ │ ├── rusoto_credential 0.45.0 │ │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ ├── rusoto_core 0.45.0 │ │ ├── reqwest 0.10.8 │ │ │ ├── xaynet-sdk 0.1.0 │ │ │ ├── influxdb 0.1.0 │ │ │ │ └── xaynet-server 0.1.0 │ │ │ └── examples 0.0.0 │ │ ├── hyper-tls 0.4.3 │ │ │ ├── rusoto_core 0.45.0 │ │ │ └── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ │ └── reqwest 0.10.8 │ ├── tokio-tungstenite 0.11.0 │ │ └── warp 0.2.5 │ ├── tokio-tls 0.3.1 │ │ ├── reqwest 0.10.8 │ │ └── hyper-tls 0.4.3 │ ├── tokio-test 0.2.1 │ │ ├── xaynet-server 0.1.0 │ │ ├── xaynet-sdk 0.1.0 │ │ └── tower-test 0.3.0 │ ├── tokio-rustls 0.14.1 │ │ ├── warp 0.2.5 │ │ ├── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ ├── rusoto_signature 0.45.0 │ ├── rusoto_credential 0.45.0 │ ├── rusoto_core 0.45.0 │ ├── reqwest 0.10.8 │ ├── redis 0.17.0 │ ├── hyper-tls 0.4.3 │ ├── hyper-rustls 0.21.0 │ ├── hyper 0.13.9 │ ├── h2 0.2.7 │ ├── examples 0.0.0 │ └── combine 4.4.0 │ └── redis 0.17.0 ├── mio-uds 0.6.8 │ └── tokio 0.2.23 └── mio-named-pipes 0.1.7 └── tokio 0.2.23 ``` ### `stdweb` 0.4.20 ``` Crate: stdweb Version: 0.4.20 Warning: unmaintained Title: stdweb is unmaintained Date: 2020-05-04 ID: RUSTSEC-2020-0056 URL: https://rustsec.org/advisories/RUSTSEC-2020-0056 Dependency tree: stdweb 0.4.20 └── time 0.2.23 ``` This is fixed in `time` 0.3, which hasn't been released yet. I don't think we depend on it anyway, because this is an optional dependency for webassembly.
little-dude
added a commit
to xaynetwork/xaynet
that referenced
this pull request
Nov 19, 2020
…7396 `cargo-audit` still spits a few warnings ### `dirs` 2.0.2 ``` Crate: dirs Version: 2.0.2 Warning: unmaintained Title: dirs is unmaintained, use dirs-next instead Date: 2020-10-16 ID: RUSTSEC-2020-0053 URL: https://rustsec.org/advisories/RUSTSEC-2020-0053 Dependency tree: dirs 2.0.2 └── rusoto_credential 0.45.0 ├── rusoto_signature 0.45.0 │ └── rusoto_core 0.45.0 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ └── rusoto_s3 0.45.0 │ └── xaynet-server 0.1.0 └── rusoto_core 0.45.0 ``` This should be fixed by rusoto/rusoto#1846 ### `failure` 0.1.8 ``` Crate: failure Version: 0.1.8 Warning: unmaintained Title: failure is officially deprecated/unmaintained Date: 2020-05-02 ID: RUSTSEC-2020-0036 URL: https://rustsec.org/advisories/RUSTSEC-2020-0036 Dependency tree: failure 0.1.8 └── influxdb 0.1.0 └── xaynet-server 0.1.0 └── xaynet 0.10.0 ``` It is fixed in `influxdb` 0.2: influxdb-rs/influxdb-rust#70. We should upgrade. ### `net2` Much more tricky. This comes from `tokio` 0.2, which we heavily depends on, both explicitely and transitively. This is going to take time, but at the same time, there's not real emergency. ``` Crate: net2 Version: 0.2.35 Warning: unmaintained Title: `net2` crate has been deprecated; use `socket2` instead Date: 2020-05-01 ID: RUSTSEC-2020-0016 URL: https://rustsec.org/advisories/RUSTSEC-2020-0016 Dependency tree: net2 0.2.35 ├── miow 0.2.1 └── mio 0.6.22 ├── tokio 0.2.23 │ ├── xaynet-server 0.1.0 │ │ └── xaynet 0.10.0 │ ├── xaynet-sdk 0.1.0 │ │ ├── xaynet-mobile 0.0.0 │ │ ├── xaynet 0.10.0 │ │ └── examples 0.0.0 │ ├── xaynet-mobile 0.0.0 │ ├── warp 0.2.5 │ │ └── xaynet-server 0.1.0 │ ├── tower-timeout 0.3.0 │ │ └── tower 0.3.1 │ │ └── xaynet-server 0.1.0 │ ├── tower-test 0.3.0 │ │ └── xaynet-server 0.1.0 │ ├── tower-retry 0.3.0 │ │ └── tower 0.3.1 │ ├── tower-load 0.3.0 │ │ └── tower-limit 0.3.1 │ │ └── tower 0.3.1 │ ├── tower-limit 0.3.1 │ ├── tower-buffer 0.3.0 │ │ └── tower 0.3.1 │ ├── tokio-util 0.3.1 │ │ ├── redis 0.17.0 │ │ │ └── xaynet-server 0.1.0 │ │ └── h2 0.2.7 │ │ └── hyper 0.13.9 │ │ ├── warp 0.2.5 │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ │ ├── xaynet-server 0.1.0 │ │ │ └── rusoto_s3 0.45.0 │ │ │ └── xaynet-server 0.1.0 │ │ ├── rusoto_credential 0.45.0 │ │ │ ├── rusoto_signature 0.45.0 │ │ │ └── rusoto_core 0.45.0 │ │ ├── rusoto_core 0.45.0 │ │ ├── reqwest 0.10.8 │ │ │ ├── xaynet-sdk 0.1.0 │ │ │ ├── influxdb 0.1.0 │ │ │ │ └── xaynet-server 0.1.0 │ │ │ └── examples 0.0.0 │ │ ├── hyper-tls 0.4.3 │ │ │ ├── rusoto_core 0.45.0 │ │ │ └── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ │ └── reqwest 0.10.8 │ ├── tokio-tungstenite 0.11.0 │ │ └── warp 0.2.5 │ ├── tokio-tls 0.3.1 │ │ ├── reqwest 0.10.8 │ │ └── hyper-tls 0.4.3 │ ├── tokio-test 0.2.1 │ │ ├── xaynet-server 0.1.0 │ │ ├── xaynet-sdk 0.1.0 │ │ └── tower-test 0.3.0 │ ├── tokio-rustls 0.14.1 │ │ ├── warp 0.2.5 │ │ ├── reqwest 0.10.8 │ │ └── hyper-rustls 0.21.0 │ ├── rusoto_signature 0.45.0 │ ├── rusoto_credential 0.45.0 │ ├── rusoto_core 0.45.0 │ ├── reqwest 0.10.8 │ ├── redis 0.17.0 │ ├── hyper-tls 0.4.3 │ ├── hyper-rustls 0.21.0 │ ├── hyper 0.13.9 │ ├── h2 0.2.7 │ ├── examples 0.0.0 │ └── combine 4.4.0 │ └── redis 0.17.0 ├── mio-uds 0.6.8 │ └── tokio 0.2.23 └── mio-named-pipes 0.1.7 └── tokio 0.2.23 ``` ### `stdweb` 0.4.20 ``` Crate: stdweb Version: 0.4.20 Warning: unmaintained Title: stdweb is unmaintained Date: 2020-05-04 ID: RUSTSEC-2020-0056 URL: https://rustsec.org/advisories/RUSTSEC-2020-0056 Dependency tree: stdweb 0.4.20 └── time 0.2.23 ``` This is fixed in `time` 0.3, which hasn't been released yet. I don't think we depend on it anyway, because this is an optional dependency for webassembly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48