-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add async-std support and replaced reqwest with surf (#58) #72
Conversation
Thanks for this PR! Could we add two flags ( Also, I'd like to merge #73 first, so the changed calls can be ported over to surf as well. |
I'm not sure to understand the purpose of adding But you're right about giving the user the possibility to choose the http backend. |
Hi @Empty2k12, I updated this PR with latest status, merging with #73. Note that switching to |
Hi @Empty2k12 , Any concern or issue reviewing this PR ? |
Sorry, I'm quite busy with university right now. Tested your PR and will merge it now. |
Thanks for the merge! (and sorry for the "harassment" 😉 ) |
@JEnoch Yes, I plan releasing this as 0.3.0. |
@JEnoch The version is now available under 0.3.0 at crates.io: https://crates.io/crates/influxdb Thanks again for your contribution! |
@Empty2k12 That's great, thanks a lot! I just made eclipse-zenoh to use it (eclipse-zenoh/zenoh@a206fa83). |
Description
This PR replaces reqwest usage with surf usage that supports both
tokio
andasync-std
. It also modifies the tests to run with both.Fixes #58.
Checklist
cargo fmt --all
cargo clippy --all-targets --all-features -- -D warnings
cargo readme -r influxdb -t ../README.tpl > README.md