Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test against MSRV #77

Merged
merged 4 commits into from
Dec 14, 2020
Merged

CI: test against MSRV #77

merged 4 commits into from
Dec 14, 2020

Conversation

msrd0
Copy link
Collaborator

@msrd0 msrd0 commented Dec 14, 2020

Description

  • Bump the MSRV to 1.45 so that all dependencies compile
  • Test against the MSRV
  • Other small improvements: Use the same github action to download rust and don't run actions/checkout multiple times

Checklist

  • N/A Formatted code using cargo fmt --all
  • N/A Linted code using clippy cargo clippy --all-targets --all-features -- -D warnings
  • ✅ Updated README.md using cargo readme -r influxdb -t ../README.tpl > README.md
  • ✅ Reviewed the diff. Did you leave any print statements or unnecessary comments?
  • N/A Any unfinished work that warrants a separate issue captured in an issue with a TODO code comment

@Empty2k12
Copy link
Collaborator

Very useful change! Thanks a lot!

I'm always happy when best practices are implemented into the project.

@Empty2k12 Empty2k12 merged commit 2887003 into influxdb-rs:master Dec 14, 2020
@msrd0 msrd0 deleted the github-actions-verify-msrv branch December 14, 2020 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants