Numeric aggregation check #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
otoolep
force-pushed
the
numeric_agg_check
branch
3 times, most recently
from
c458697
to
da1a900
Compare
| // IsNumeric returns whether a given aggregate can only be run on numeric fields. | ||
| func IsNumeric(c *Call) bool { | ||
| switch c.Name { | ||
| case "sum", "mean", "median", "min", "max", "spread", "stddev", "percentile": |
There was a problem hiding this comment.
I would invert this. We should assume that the aggregate is numeric since it most cases it is. That way the check in planning will get run by default if someone adds a new aggregate function but forgets to add it here.
There was a problem hiding this comment.
Yeah, @beckettsean and I were just discussing doing exactly that.
otoolep
force-pushed
the
numeric_agg_check
branch
2 times, most recently
from
006556c
to
392232c
Compare
|
Fixed a logic bug in there, updated PR pushed. I will make the other suggested changes now. |
otoolep
force-pushed
the
numeric_agg_check
branch
from
392232c
to
f289808
Compare
This check has been moved to earlier in the planning phase.
otoolep
force-pushed
the
numeric_agg_check
branch
from
f289808
to
5a00991
Compare
otoolep
force-pushed
the
numeric_agg_check
branch
from
5a00991
to
573e705
Compare
|
All requested changes made. |
|
+1 |
|
looks rad, +1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change in place, an error will be returned to the client if an attempt is made to perform a numeric aggregation on non-numeric data.
Fixes issues #2299, #2062, #2543.