Fill should fill the entire time range that is requested #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 24, 2014
Closed
Prior to this change, empty group filling worked between t1 and t2, where t1 is the timestamp of the earliest point and t2 is the timestamp of the last point. This patch change the behavior of the fill() to use the query start and end time as t1 and t2, respectively. This only happens if the user specified the start time of the query. Otherwise, there's a potential of filling millions of millions of groups, since the default start time of the query is really really early.
pauldix
added a commit
that referenced
this pull request
Aug 6, 2014
Fill should fill the entire time range that is requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #117 for info on the fill function. Based on that discussion, we should be filling for the entire requested time range. If you try to graph two weeks of data and it doesn't fill at the edges and you only see a few days of data, that's bad.
So, for any query that has a
where time > ...clause in it, make sure you fill from that time to whenever the end time is.