Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed missing queryString assignment #561

Closed
wants to merge 1 commit into from
Closed

fixed missing queryString assignment #561

wants to merge 1 commit into from

Conversation

chobie
Copy link
Contributor

@chobie chobie commented May 21, 2014

I've noticed http api returns strange error message when I send wrong query.

syntax error, unexpected ')'

        ^

this pull request improve it.

@chobie
Copy link
Contributor Author

chobie commented May 21, 2014

Whole test suite failed on travis but added test passed.

PASS: parser_test.go:914: QueryParserSuite.TestQueryErrorShouldHaveQueryString  0.000s

@jvshahid jvshahid closed this in b0f99d0 May 21, 2014
@jvshahid
Copy link
Contributor

thanks @chobie

pauldix pushed a commit that referenced this pull request May 27, 2014
@chobie @pauldix
Close #561. Fix missing query string in parser errors
d9cc770
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chobie @jvshahid